New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom#timeout duplicates async#disposableTimeout #66878

Closed

jrieken opened this issue Jan 22, 2019 · 1 comment

Assignees

Labels

Milestone

December/January ...

Member

jrieken commented Jan 22, 2019

See https://github.com/Microsoft/vscode/blob/c52a3010e6f00e6779f4537f6c5a7bc18a6d5176/src/vs/base/browser/dom.ts#L1170-L1174 (younger) and https://github.com/Microsoft/vscode/blob/c52a3010e6f00e6779f4537f6c5a7bc18a6d5176/src/vs/base/common/async.ts#L321-L329 (older)

jrieken assigned joaomoreno

jrieken added the perf-bloat label

Member

joaomoreno commented Jan 23, 2019

Oh! Funny how there's only one use of the disposableTimeout and its return value isn't even saved. 😆

joaomoreno added this to the December/January 2019 milestone

joaomoreno closed this as completed in

f620b3d

vscodebot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.