Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write code that doesn't work on IE11 #66876

Closed
jrieken opened this issue Jan 22, 2019 · 1 comment
Closed

Don't write code that doesn't work on IE11 #66876

jrieken opened this issue Jan 22, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug engineering VS Code - Build / issue tracking / etc. verified Verification succeeded

Comments

@jrieken
Copy link
Member

jrieken commented Jan 22, 2019

Like this: https://github.com/Microsoft/vscode/blob/e83c7a08a9340f817f708aed0e773d755a7a52f6/src/vs/platform/url/common/urlService.ts#L11-L13. I know it's not cool, but you'll have to use the values-util instead. There is no point in running double compiles et all if we just slip declaration like this into the common layer 🚓

@joaomoreno joaomoreno added this to the December/January 2019 milestone Jan 23, 2019
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jan 23, 2019
@joaomoreno
Copy link
Member

I must say that was a bit reckless on my part. 🤐

@mjbvz mjbvz added verified Verification succeeded engineering VS Code - Build / issue tracking / etc. labels Jan 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug engineering VS Code - Build / issue tracking / etc. verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants