-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start without debug option to TouchBar #60777
Comments
@guidobouman this is a fair feature request. For us to add it to the touch bar we would also need a new icon which would be easily distinguihsable from the current start icon (green play). I would also check what icon Visual Studio is using. |
Visual Studio uses a same filled play icon for the default start action. It differentiates with an outline version of that same icon for starting without debugging. Seems reasonable? |
Makes somewhat sense. Can you design that icon froum our start icon? fyi @misolori |
Wait, shouldn't it be the one from Anyhow, I made a mockup based on the old designs found in Visual Studio: The stripes indicate that it's faster than full debug. While the hollow arrow indicates that it's not as complete as debugging. SVG: Alternatively it could look like this: But, in my opinion, it does not convey the faster execution as well. |
Not sure if the three lines fit the rest of our icons, I'd go with just the outline. Thanks for creating this! |
@guidobouman I like how you explained the icons and I agree with your point of view. |
I'll check! I don't think it has multiple themes though. And what about the location? I think it's the white icon from the |
You are correct, here is the location https://github.com/Microsoft/vscode/blob/26d62c4b9f7c5ee94975bc2ff14b17426dc0d483/src/vs/workbench/parts/debug/electron-browser/media/continue-tb.png |
I would not change the current shape. |
About the theming: Apple states that you should supply themed images (black on transparent), but I don't see these in the VS Code codebase. So I guess Electron has a specific implementation to translate the png icons to TouchBar-safe icons. The png resolution does not seem to match up either, even though it does look good on the TouchBar. |
Thanks for looking into this. |
Pinging @misolori on the design decision. |
Sorry about that, this somehow fall off my radar. |
I'll start a PR in the meantime. |
Verification steps:
|
It's clear that the usual set of icons is a minimal case, and that you want the default set to stay minimal. But I think the option to differentiate between start with or without debugging is a feature that every developer could use. Maybe an option in the config to switch the current
start
command tostart without debug
would already be enough.Yes, a plugin could add an extra button. But I don't think this belongs within a plugin, as it's an extension of the existing
start
button.I'm willing to do the work required. But before that: what are your preferences?
The text was updated successfully, but these errors were encountered: