Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] Closing fold not being shown when folding #47240

Closed
etiennejcharles opened this issue Apr 5, 2018 · 4 comments
Closed

[folding] Closing fold not being shown when folding #47240

etiennejcharles opened this issue Apr 5, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Milestone

Comments

@etiennejcharles
Copy link

When I fold I like to see my last character, but in visual studio code insiders I can't :(
It works in Visual Studio stable version. (Version 1.21.1)

example

  • VSCode Version: Version 1.22.0-insider (1.22.0-insider)
  • OS Version: Mac OS HIGH Sierra 10.13.3

Steps to Reproduce:

  1. Open Visual Studio Code Insiders.
  2. Set language to javascript.
  3. Paste some javascript code.
  4. Try to fold some code

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the insiders label Apr 5, 2018
@vscodebot
Copy link

vscodebot bot commented Apr 5, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@etiennejcharles etiennejcharles changed the title [folding] Closing fold not being showed when folding [folding] Closing fold not being shown when folding Apr 5, 2018
@vscodebot vscodebot bot removed the insiders label Apr 5, 2018
@aeschli aeschli assigned mjbvz and unassigned aeschli Apr 6, 2018
@Spown
Copy link

Spown commented Apr 7, 2018

Eyep, when using "editor.foldingStrategy": "auto" the block-closing bracket and everything after on the same line gets eaten up. Unlike it is with "editor.foldingStrategy": "indentation". It can be extremely misleading, like for example in if else case:

VS. "editor.foldingStrategy": "indentation"

@aeschli
Copy link
Contributor

aeschli commented Apr 8, 2018

@mjbvz I wonder if we should disable the syntax aware folding again for the stable rebuild. There will many duplicates of this issue and we don't want tell everybody to turn off the experimental folding

@mjbvz mjbvz added this to the April 2018 milestone Apr 9, 2018
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues javascript JavaScript support issues editor-folding Editor code folding issues labels Apr 10, 2018
@mjbvz mjbvz closed this as completed in 9aef83c Apr 10, 2018
@ywang04
Copy link

ywang04 commented Apr 11, 2018

The same issue for jsx codes in React.

@rebornix rebornix added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants