Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell tasks force terminal window regardless of presentation setting #45261

Closed
babakness opened this issue Mar 8, 2018 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@babakness
Copy link

  • VSCode Version: 1.20.1
  • OS Version: MacOs Sierra

Steps to Reproduce:

  1. Run Shell Task
  2. Have no way to prevent switching to output of shell task in terminal window

Details:

I would like to be able to run a shell task without interrupting the terminal window. At the moment there is a switch over to shared terminal tab; I'd like for there to be some way to keep the messages in the tab but not switch over to the tab to see the output.

{
      "label": "tscc",
      "type": "shell",
      "command": "echo 'this is a sample'",
      "presentation": {
        "echo": false,
        "reveal": "never",
        "focus": false,
        "panel": "shared"
      }
    },
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Mar 8, 2018
@Tyriar
Copy link
Member

Tyriar commented Mar 9, 2018

@babakness tasks in output is deprecated, I think you should be able to create task terminals in the background though?

@Tyriar Tyriar assigned dbaeumer and unassigned Tyriar Mar 9, 2018
@Tyriar Tyriar added tasks Task system issues and removed terminal Integrated terminal issues labels Mar 9, 2018
@dbaeumer
Copy link
Member

@Tyriar the problem is if there is a terminal instance already showing then the task terminal comes to front. I do call this.terminalService.setActiveInstance(terminal); but only this.terminalService.showPanel if the reveal kind !== never. Will setActiveInstance bring it to front. What is the consequence of me not calling it.

@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Mar 12, 2018
@dbaeumer dbaeumer added this to the March 2018 milestone Mar 12, 2018
@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2018

@dbaeumer not calling setActiveInstance should be fine. The task will still run in the background, but there will be no indication to the user that it was launched.

@rebornix rebornix added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants