-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable terminal chat hint permanently when the user has triggered ctrl+i #213820
Comments
it's a little weird IMO that we will do this for the terminal and not for untitled editors, which I see more often than empty terminals |
Yeah, maybe it should there too though? |
I think these should be consistent experiences, so maybe we should discuss before merging this? |
They're already not consistent as we only show there there's a single terminal and will show in a different color. The main take away I got from the discussion in #ux was that we need to reduce the amount it's shown and this suggestion got a bunch of upvotes from the team. Having it in an empty editor is less disruptive. |
I am concerned about the lack of discoverability if we go with this approach. We could fix the color. Showing it only when there's a single terminal means it's inherently less disruptive. Notebooks also don't do this. |
This would help IMO, but still, not sure why we don't do this in other places, like notebooks. |
@meganrogge but the user has discovered it and triggered if we hide it. Notebooks should do it as well, I think @rebornix mentioned people complain about it showing up in every cell which is a very common occurrence in notebooks. |
as long as notebooks follow suit here, this sounds good to me. |
I still see the hint show:
|
Previously this would only happen when _clicked_. Fixes microsoft#213820
This will help resolve the issue of it being too distracting. I don't often like having state like this that cannot be reverted, but in this case I think it makes sense. It might also be better to hide only when a question has been asked, not just on open.
The text was updated successfully, but these errors were encountered: