Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable terminal chat hint permanently when the user has triggered ctrl+i #213820

Closed
Tyriar opened this issue May 29, 2024 · 9 comments · Fixed by #214028 or #218439
Closed

Disable terminal chat hint permanently when the user has triggered ctrl+i #213820

Tyriar opened this issue May 29, 2024 · 9 comments · Fixed by #214028 or #218439
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-chat Issues related to the terminal chat widget verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 29, 2024

This will help resolve the issue of it being too distracting. I don't often like having state like this that cannot be reverted, but in this case I think it makes sense. It might also be better to hide only when a question has been asked, not just on open.

@Tyriar Tyriar added feature-request Request for new features or functionality terminal-chat Issues related to the terminal chat widget labels May 29, 2024
@Tyriar Tyriar added this to the June 2024 milestone May 29, 2024
@meganrogge
Copy link
Contributor

it's a little weird IMO that we will do this for the terminal and not for untitled editors, which I see more often than empty terminals

@Tyriar
Copy link
Member Author

Tyriar commented May 31, 2024

Yeah, maybe it should there too though?

@meganrogge
Copy link
Contributor

I think these should be consistent experiences, so maybe we should discuss before merging this?

@Tyriar
Copy link
Member Author

Tyriar commented May 31, 2024

They're already not consistent as we only show there there's a single terminal and will show in a different color. The main take away I got from the discussion in #ux was that we need to reduce the amount it's shown and this suggestion got a bunch of upvotes from the team. Having it in an empty editor is less disruptive.

@meganrogge
Copy link
Contributor

I am concerned about the lack of discoverability if we go with this approach.

We could fix the color. Showing it only when there's a single terminal means it's inherently less disruptive.

Notebooks also don't do this.

@meganrogge
Copy link
Contributor

It might also be better to hide only when a question has been asked, not just on open.

This would help IMO, but still, not sure why we don't do this in other places, like notebooks.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 3, 2024

@meganrogge but the user has discovered it and triggered if we hide it. Notebooks should do it as well, I think @rebornix mentioned people complain about it showing up in every cell which is a very common occurrence in notebooks.

@meganrogge
Copy link
Contributor

as long as notebooks follow suit here, this sounds good to me.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 3, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 5, 2024
@Yoyokrazy Yoyokrazy added the verification-needed Verification of issue is requested label Jun 25, 2024
@alexr00
Copy link
Member

alexr00 commented Jun 25, 2024

I still see the hint show:

  1. Turn the hint on with the setting
  2. Open a terminal, see the hint
  3. ctrl+i in the terminal and ask some questions. I repeated this at least 3 times.
  4. Kill the terminal
  5. Reload
  6. Focus into a new terminal. Hint still shows.

@alexr00 alexr00 added the verification-found Issue verification failed label Jun 25, 2024
@alexr00 alexr00 reopened this Jun 25, 2024
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jun 25, 2024
@Tyriar Tyriar closed this as completed in 47262be Jun 26, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 26, 2024
@Tyriar Tyriar removed the verification-found Issue verification failed label Jun 26, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 26, 2024
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 26, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
Previously this would only happen when _clicked_.

Fixes microsoft#213820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-chat Issues related to the terminal chat widget verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
6 participants