Leak warnings in notebook outline

[roblourens]

• Used the github issue notebook for awhile
• Saw a ton of event leak warnings

The full output is below, but I deminified a couple

2024-06-25 15:26:02.451 [error] [150] potential listener LEAK detected, having 207 listeners already. MOST frequent listener (21):: Error
  at ./base/common/event.ts:902:14
  at ./base/common/event.ts:1109:33
  at ./platform/actions/common/menuService.ts:395:33
  at ./base/common/event.ts:1118:44
  at ./workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts:219:43
  at ./workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts:184:8
  at ./base/browser/ui/tree/abstractTree.ts:418:16
  at ./base/browser/ui/list/listWidget.ts:1249:12
  at ./base/browser/ui/list/listView.ts:940:12
  at ./base/browser/ui/list/listView.ts:675:9
  at ./base/browser/ui/list/listView.ts:576:15
  at ./base/browser/ui/list/splice.ts:17:34
  at ./base/browser/ui/list/splice.ts:17:19
  at ./base/browser/ui/list/listWidget.ts:1585:56
  at fn (./base/common/event.ts:1684:12)
  at ./base/browser/ui/list/listWidget.ts:1585:21
  at ./base/browser/ui/tree/abstractTree.ts:2390:8
  at ./base/browser/ui/tree/indexTreeModel.ts:308:13
  at ./base/browser/ui/tree/indexTreeModel.ts:160:8
  at ./base/browser/ui/tree/objectTreeModel.ts:122:13
  at ./base/browser/ui/tree/objectTreeModel.ts:71:7
  at ./base/browser/ui/tree/dataTree.ts:155:13
  at ./base/browser/ui/tree/dataTree.ts:110:7
  at ./workbench/contrib/outline/browser/outlinePane.ts:290:9
  at ./base/common/event.ts:1211:12
  at ./base/common/event.ts:1222:8
  at ./base/common/event.ts:1246:8
  at ./workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts:666:22
  at ./base/common/event.ts:1211:12
  at ./base/common/event.ts:1222:8
  at ./base/common/event.ts:1246:8
  at ./workbench/contrib/notebook/browser/viewModel/notebookOutlineDataSource.ts:168:24
  at ./base/common/event.ts:1211:12
  at ./base/common/event.ts:1222:8
  at ./base/common/event.ts:1246:8
  at ./base/common/event.ts:1390:11
  at ./base/common/event.ts:1429:9

2024-06-25 15:32:11.815 [error] [150] potential listener LEAK detected, having 211 listeners already. MOST frequent listener (21):: Error
  at ./base/common/event.ts:902:14
  at ./base/common/event.ts:1109:33
  at ./platform/actions/common/menuService.ts:395:33
  at ./base/common/event.ts:1118:44
  at ./workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts:219:43
  at ./workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts:184:8
  at ./base/browser/ui/tree/abstractTree.ts:418:16
  at ./base/browser/ui/list/listWidget.ts:1249:12
  at ./base/browser/ui/list/listView.ts:940:12
  at ./base/browser/ui/list/listView.ts:675:9
  at ./base/browser/ui/list/listView.ts:576:15
  at ./base/browser/ui/list/splice.ts:17:34
  at ./base/browser/ui/list/splice.ts:17:19
  at ./base/browser/ui/list/listWidget.ts:1585:56
  at fn (./base/common/event.ts:1684:12)
  at ./base/browser/ui/list/listWidget.ts:1585:21
  at ./base/browser/ui/tree/abstractTree.ts:2390:8
  at ./base/browser/ui/tree/indexTreeModel.ts:308:13
  at ./base/browser/ui/tree/indexTreeModel.ts:160:8
  at ./base/browser/ui/tree/objectTreeModel.ts:122:13
  at ./base/browser/ui/tree/objectTreeModel.ts:71:7
  at ./base/browser/ui/tree/dataTree.ts:155:13
  at ./base/browser/ui/tree/dataTree.ts:110:7
  at ./workbench/contrib/outline/browser/outlinePane.ts:290:9
  at ./base/common/event.ts:1211:12
  at ./base/common/event.ts:1222:8
  at ./base/common/event.ts:1246:8
  at ./workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts:666:22
  at ./base/common/event.ts:1211:12
  at ./base/common/event.ts:1222:8
  at ./base/common/event.ts:1246:8
  at ./workbench/contrib/notebook/browser/viewModel/notebookOutlineDataSource.ts:168:24
  at ./base/common/event.ts:1211:12
  at ./base/common/event.ts:1222:8
  at ./base/common/event.ts:1246:8
  at ./base/common/event.ts:1390:11
  at ./base/common/event.ts:1429:9

notebookLeaks.log

[VSCodeTriageBot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!