Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I wonder if the graph is high contrast enough for high contrast themes #218227

Open
TylerLeonhardt opened this issue Jun 25, 2024 · 3 comments
Open
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues scm General SCM compound issues
Milestone

Comments

@TylerLeonhardt
Copy link
Member

Testing #217398

image

I'm not actually sure... but it feels not.

cc @daviddossett

@daviddossett
Copy link
Contributor

@lszomoru maybe you can reuse focusBorder and contrastBorder for at least some of these? Better yet, used dashed and/or dotted lines since it will be so hard to distinguish between colors in the first place.

@lszomoru lszomoru added scm General SCM compound issues accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jun 26, 2024
@lszomoru
Copy link
Member

Thanks @daviddossett. I would love to work with you or @hbons next milestone to create a color palette that would be used for the various swim lanes of the graph.

@lszomoru lszomoru modified the milestone: July 2024 Jun 26, 2024
@daviddossett
Copy link
Contributor

I'd suggest starting with those two colors for the first two levels in hc-light and hc-dark themes and we can see how it feels. Maybe from there we just alternate between the two and then start using different stroke patterns for nth-of-type(3), and so on.

It's unlikely that we will have many color options in an HC context that will actually have enough meaningful contrast between themselves.

@lszomoru lszomoru modified the milestones: July 2024, Backlog Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues scm General SCM compound issues
Projects
None yet
Development

No branches or pull requests

3 participants