Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top pixels of terminal are cut off #218090

Closed
connor4312 opened this issue Jun 25, 2024 · 5 comments
Closed

Top pixels of terminal are cut off #218090

connor4312 opened this issue Jun 25, 2024 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@connor4312
Copy link
Member

Using the latest Insiders on Fedora:

image

This was after opening a terminal the first time, I didn't resize the bottom panel or anything, although the cutoff persists even when I do resize it.

@connor4312
Copy link
Member Author

Actually, I realized this is the top pixels of every line, not just the top line. This happens with a fresh profile with default settings on Fedora.

@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2024

@connor4312 this isn't a new issue is it? I think some fonts on Linux distros have weird font metrics for which there are some workaround here:

// Work around bad font on Fedora/Ubuntu
if (!this._terminalConfigurationService.config.fontFamily) {
if (this.linuxDistro === LinuxDistro.Fedora) {
fontFamily = '\'DejaVu Sans Mono\'';
}
if (this.linuxDistro === LinuxDistro.Ubuntu) {
fontFamily = '\'Ubuntu Mono\'';
// Ubuntu mono is somehow smaller, so set fontSize a bit larger to get the same perceived size.
fontSize = clampInt(fontSize + 2, FontConstants.MinimumFontSize, FontConstants.MaximumFontSize, EDITOR_FONT_DEFAULTS.fontSize);
}
}

Also what version of Fedora?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jun 25, 2024
@connor4312
Copy link
Member Author

Oh, perhaps. I just updated to Fedora 40.

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2024

@connor4312 did you use an older version and you would have noticed there?

@VSCodeTriageBot
Copy link
Collaborator

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants