Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceWorker: workbench.web.main.nls.js is blocked #218050

Closed
jrieken opened this issue Jun 25, 2024 · 2 comments
Closed

ServiceWorker: workbench.web.main.nls.js is blocked #218050

jrieken opened this issue Jun 25, 2024 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox web Issues related to running VSCode in the web

Comments

@jrieken
Copy link
Member

jrieken commented Jun 25, 2024

Testing #216888

The resource at “https://main.vscode-cdn.net/insider/43f70eca0c428e6f1a5bfad59a9b2a66f99b748d/out/vs/workbench/workbench.web.main.nls.js” was blocked due to its Cross-Origin-Resource-Policy header (or lack thereof). See https://developer.mozilla.org/docs/Web/HTTP/Cross-Origin_Resource_Policy_(CORP)#
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug web Issues related to running VSCode in the web firefox Issues running VSCode in Web on Firefox labels Jun 25, 2024
@bpasero bpasero added this to the June 2024 milestone Jun 25, 2024
@bpasero
Copy link
Member

bpasero commented Jun 25, 2024

Hm, I am a bit clueless here. It seems to happen when a request results in a 404 and then maybe the service worker tries to step in and attempts to load it from there in the background and then hits CORP issues?

The 404 will go away once we ship the new solution, currently vscode.dev is in a hybrid mode.

@bpasero bpasero changed the title workbench.web.main.nls.js is blocked ServiceWorker: workbench.web.main.nls.js is blocked Jun 25, 2024
@bpasero bpasero modified the milestones: June 2024, July 2024 Jun 26, 2024
@bpasero
Copy link
Member

bpasero commented Jun 28, 2024

Merging into https://github.com/microsoft/vscode-dev/issues/1157. We should not load this file with newer versions, but I would only do that change when we are back from vacation season.

@bpasero bpasero closed this as completed Jun 28, 2024
@roblourens roblourens removed this from the July 2024 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

4 participants