Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest commands are not serialized #216818

Closed
Tyriar opened this issue Jun 21, 2024 · 2 comments
Closed

Suggest commands are not serialized #216818

Tyriar opened this issue Jun 21, 2024 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-pwsh An issue in the terminal specific to PowerShell terminal-suggest verified Verification succeeded
Milestone
July 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 21, 2024

Related: #210753

Currently on shell start up all aliases/commands are sent over from pwsh. This is not being serialized land restored so suggest doesn't work properly after.

Before reload:

image

After reload:

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-shell-pwsh An issue in the terminal specific to PowerShell terminal-suggest labels Jun 21, 2024
@Tyriar Tyriar added this to the June 2024 milestone Jun 21, 2024
@Tyriar Tyriar self-assigned this Jun 21, 2024
@Tyriar Tyriar modified the milestones: June 2024, Backlog Jun 26, 2024
@Tyriar Tyriar mentioned this issue Jun 26, 2024
Closed
@Tyriar Tyriar modified the milestones: Backlog, July 2024 Jul 22, 2024
@Tyriar Tyriar closed this as completed Jul 22, 2024
@alexr00
Copy link
Member

alexr00 commented Jul 25, 2024

Am I verifying this correctly?

  1. Install the PowerShell extension
  2. New pwsh terminal
  3. G in the terminal
  4. See suggest show with lots of good cmdlet suggestions
  5. Reload window.
  6. G in the same re-attached terminal
  7. See suggest show with lots of good cmdlet suggestions

@alexr00 alexr00 added the verified Verification succeeded label Jul 25, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Jul 25, 2024

yep 👍

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-pwsh An issue in the terminal specific to PowerShell terminal-suggest verified Verification succeeded
Projects
None yet
Milestone
July 2024
Development

No branches or pull requests
2 participants
@Tyriar @alexr00