Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--unity-launch option removal causes VSCode to ignore input file #214137

Open
Ved-s opened this issue Jun 3, 2024 · 3 comments
Open

--unity-launch option removal causes VSCode to ignore input file #214137

Ved-s opened this issue Jun 3, 2024 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmation-pending deb Issues related to the deb package debt Code quality issues linux Issues with VS Code on Linux
Milestone

Comments

@Ved-s
Copy link

Ved-s commented Jun 3, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.89.1 dc96b83 x64
  • OS Version: Ubuntu 22.04

Steps to Reproduce:

  1. run VSCode with code --unity-launch some-file
  2. it prints Warning: 'unity-launch' is not in the list of known options, but still passed to Electron/Chromium.
  3. file doesn't open in VSCode as it's being treated as an argument to the unknown --unity-launch option

.desktop file for VSCode uses this option. It either wasn't updated when this option was removed or it may still install VSCode with this option in its .desktop file.

Also sorry if it's a duplicate, couldn't make github search by option's name

@roblourens roblourens assigned rzhao271 and unassigned roblourens Jun 3, 2024
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux labels Jun 4, 2024
@rzhao271 rzhao271 added this to the June 2024 milestone Jun 4, 2024
@rzhao271
Copy link
Contributor

rzhao271 commented Jun 6, 2024

I looked through the codebase and didn't find any mentions of --unity-launch.
I'm wondering whether the .desktop file just didn't update along with the rest of the program.
Could you update to 1.90.0 and check the file again?

@rzhao271 rzhao271 added the info-needed Issue requires more information from poster label Jun 6, 2024
@Ved-s
Copy link
Author

Ved-s commented Jun 7, 2024

I tested with code-insiders when i created the issue and i checked now, its desktop file is normal, without unity-launch. I will update code to 1.90.0 and look if its desktop file changes.

@Ved-s
Copy link
Author

Ved-s commented Jun 7, 2024

No, apt didn't update the desktop file while unpacking, but it probably will on clean reinstall

@rzhao271 rzhao271 added deb Issues related to the deb package and removed info-needed Issue requires more information from poster labels Jun 7, 2024
@rzhao271 rzhao271 modified the milestones: June 2024, July 2024 Jun 25, 2024
@rzhao271 rzhao271 added the debt Code quality issues label Jul 23, 2024
@rzhao271 rzhao271 modified the milestones: July 2024, August 2024 Jul 23, 2024
@rzhao271 rzhao271 modified the milestones: August 2024, Backlog Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmation-pending deb Issues related to the deb package debt Code quality issues linux Issues with VS Code on Linux
Projects
None yet
Development

No branches or pull requests

3 participants