Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Toggle Notebook Sticky Scroll" command naming #205308

Open
Yoyokrazy opened this issue Feb 15, 2024 · 1 comment
Open

"Toggle Notebook Sticky Scroll" command naming #205308

Yoyokrazy opened this issue Feb 15, 2024 · 1 comment
Assignees
Labels
notebook-sticky-scroll Sticky Scroll in Notebook Editor under-discussion Issue is under discussion for relevance, priority, approach

Comments

@Yoyokrazy
Copy link
Contributor

Small nit, terminal sticky scroll toggle command follows a different pattern than notebook, editor, and tree view sticky scrolls.

image
@Tyriar
Copy link
Member

Tyriar commented Feb 16, 2024

Terminal is a contrib not part of the core workbench. I think the issue here is that notebook should be Notebook: Toggle Sticky Scroll, since it's also a contrib; it's command ID does not include the workbench.view. namespace: notebook.action.toggleNotebookStickyScroll

@Tyriar Tyriar assigned Yoyokrazy and unassigned Tyriar Feb 16, 2024
@Yoyokrazy Yoyokrazy changed the title "Toggle Terminal Sticky Scroll" command naming "Toggle Notebook Sticky Scroll" command naming Apr 2, 2024
@Yoyokrazy Yoyokrazy added notebook-sticky-scroll Sticky Scroll in Notebook Editor under-discussion Issue is under discussion for relevance, priority, approach labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook-sticky-scroll Sticky Scroll in Notebook Editor under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants