Formatting [dotenv] against my explicit consent

[flexchar]

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.85.1
Commit: 0ee08df
Date: 2023-12-13T09:48:16.874Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.2.0

Steps to Reproduce:

1. Open .env file and save.
2. It will get formatted if defaultFormatter is set, or show a pop asking to configure one.

GUI Example:

• getting a popup if I hide default formatter in the settings as such

"[dotenv]": {
    // "editor.defaultFormatter": "foxundermoon.shell-format",
    "editor.formatOnSave": false,
    "editor.codeActionsOnSave": {
        "source.fixAll": false,
        "formatOnSave": false
    }
}

• file gets formatted against my explicit consent stating "editor.formatOnSave": false when settings are

 "[dotenv]": {
    "editor.defaultFormatter": "foxundermoon.shell-format",
    "editor.formatOnSave": false,
    "editor.codeActionsOnSave": {
        "source.fixAll": false,
        "formatOnSave": false
    }
}

I observe the same behaviour with editor.formatOnSave set to false globally.

[flexchar]

Actually thanks to writing this issue, I discovered I was wrong.

It is the issue of the shell formatter extension, which slipped through because file type is "dot env".

Related:

• "editor.formatOnSave": false doesn't appear to be respected foxundermoon/vs-shell-format#303
• vscode ignores editor.formatOnSave = false set for language #173689