-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glyph Widgets Operate On View Positions, Not Model Positions #198674
Labels
bug
Issue identified by VS Code Team member as probable bug
insiders-released
Patch has been released in VS Code Insiders
verified
Verification succeeded
Milestone
Comments
We're deciding whether to render widgets based on vscode/src/vs/editor/browser/viewParts/glyphMargin/glyphMargin.ts Lines 276 to 281 in 620340c
|
vscodenpa
added
the
unreleased
Patch has not yet been released in VS Code Insiders
label
Nov 21, 2023
vscodenpa
added
insiders-released
Patch has been released in VS Code Insiders
and removed
unreleased
Patch has not yet been released in VS Code Insiders
labels
Nov 22, 2023
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Issue identified by VS Code Team member as probable bug
insiders-released
Patch has been released in VS Code Insiders
verified
Verification succeeded
Monaco Editor Repro
As you can see, the positioning does not folding into account:
This breaks the revert arrows in the diff editor, as I adopted glyph widgets for them.
The text was updated successfully, but these errors were encountered: