Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear in docs that returning an InputBoxValidationSeverity.Error the InputBox will not be accepted #145673

Closed
isidorn opened this issue Mar 22, 2022 · 2 comments
Closed

Make it clear in docs that returning an InputBoxValidationSeverity.Error the InputBox will not be accepted #145673

isidorn opened this issue Mar 22, 2022 · 2 comments
Assignees
@TylerLeonhardt
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
April 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 22, 2022

Testing #145626

If you return an InputBoxValidationSeverity.Error the InputBox will not be accepted on Enter. This makes sense but I think it should be called out in docs. Or maybe I missed it and this is a common pattern that we already do?
@TylerLeonhardt
Copy link
Member

@isidorn I will make sure to call this out when I move to finalization. Thanks!

@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Mar 22, 2022
@TylerLeonhardt TylerLeonhardt added this to the April 2022 milestone Mar 22, 2022
@TylerLeonhardt
Copy link
Member

Verification: use the proposed API (inputBoxSeverity) and read the new docs associated with the InputBoxValidationMessage interface.

@isidorn isidorn added the verified Verification succeeded label Apr 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
3 participants
@isidorn @TylerLeonhardt and others