Closing a tab via API changes focus

[jrieken]

There is currently no way to specific the focus behaviour when closing tabs. The API usually does that via the preserveFocus boolean

[jrieken]

fyi @lszomoru this can help to keep focus inside the SCM box when making a commit. Today this happens

• many diff editor
• make a commit
• focus moves to editor pane :sad:
• I would rather keep focus in the commit box and press tab for the "big button"

[lszomoru]

@jrieken, I believe this has been addressed already by @lramos15 as he has refactored the code.

vscode/extensions/git/src/repository.ts

Line 1290 in d8a95da

window.tabGroups.close(diffEditorTabsToClose, true);

[jrieken]

Yeah, we decided to simply push that 🤓

[lramos15]

To verify:

1. Ensure "git.closeDiffOnOperation": true is in your settings
2. Open a change in the changes view
3. Stage the file
4. 🎉 It should close the diff while preserving focus