Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] Generate Color Theme From Current Settings doesn't have all colors #111147

Closed
usernamehw opened this issue Nov 22, 2020 · 0 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@usernamehw
Copy link
Contributor

usernamehw commented Nov 22, 2020

I want to get all the color ids programmatically, or as close to that as possible.

When color theme doesn't have a default value for color it's missing when executing workbench.action.generateColorTheme, for instance editor.lineHighlightBackground or menu.selectionBorder. It would be great if they appeared commented out with the null value.

@usernamehw usernamehw changed the title Generate Color Theme doesn't have all colors Generate Color Theme From Current Settings doesn't have all colors Nov 22, 2020
@aeschli aeschli changed the title Generate Color Theme From Current Settings doesn't have all colors [themes] Generate Color Theme From Current Settings doesn't have all colors Nov 23, 2020
@aeschli aeschli added feature-request Request for new features or functionality themes Color theme issues labels Nov 23, 2020
@aeschli aeschli modified the milestones: Backlog, November 2020 Nov 23, 2020
@aeschli aeschli added the verification-needed Verification of issue is requested label Dec 1, 2020
@miguelsolorio miguelsolorio added the verified Verification succeeded label Dec 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@aeschli @usernamehw @miguelsolorio and others