Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings sync: before shutdown cannot be async in web #108647

Closed
bpasero opened this issue Oct 14, 2020 · 1 comment
Closed

Settings sync: before shutdown cannot be async in web #108647

bpasero opened this issue Oct 14, 2020 · 1 comment
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders settings-sync web Issues related to running VSCode in the web
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 14, 2020

A reminder that in browser long running shutdown handlers will not work:

private async onBeforeShutdown(manualSyncTask: IManualSyncTask): Promise<boolean> {
const result = await this.dialogService.confirm({
type: 'warning',
message: localize('sync in progress', "Settings Sync is being turned on. Would you like to cancel it?"),
title: localize('settings sync', "Settings Sync"),
primaryButton: localize('yes', "Yes"),
secondaryButton: localize('no', "No"),
});
if (result.confirmed) {
await manualSyncTask.stop();
}
return !result.confirmed;
}

I suggest to move this into a electron-sandbox namespace to be clear.

@bpasero bpasero added debt Code quality issues settings-sync web Issues related to running VSCode in the web labels Oct 14, 2020
@sandy081 sandy081 added this to the November 2020 milestone Oct 19, 2020
@sandy081
Copy link
Member

sandy081 commented Dec 9, 2020

I cannot move just this to electron-sandbox, instead I will add web check and add a note that it works only in desktop.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders settings-sync web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @sandy081 and others