Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DependencyManagement(bom) & dependencies in test scope can't be removed #58

Open
bsaby opened this issue Apr 25, 2018 · 4 comments
Open
Assignees

Comments

@bsaby
Copy link

bsaby commented Apr 25, 2018

  1. Add some dependencies with bom information or repository information
  2. Edit starter, remove these dependencies
    RESULT:
    The bom or repository information can't be removed while removing related dependencies

Dependencies in test scope have the same issue.

@bsaby bsaby mentioned this issue Apr 25, 2018
9 tasks
@Eskibear
Copy link
Member

It has the same behaviour with STS IDE. Will discuss about it.

@Eskibear
Copy link
Member

Eskibear commented May 3, 2018

The remaining of existing xml nodes is not blocking, actually the blocking issue is that when you add some starters, the dependencies in test scope cannot be added. That leads to failure in build. Just as mentioned in spring-projects/sts4#52 (comment)

@kdvolder
Copy link

@Eskibear Can you elaborate what you mean by this:

when you add some starters, the dependencies in test scope cannot be added

Do you have an example of this to illustrate it perhaps? Because I don't understand.

@Eskibear Eskibear self-assigned this Jun 21, 2018
@Eskibear
Copy link
Member

@kdvolder What I meant was the example you mentioned in spring-projects/sts4#52 (comment)

If I select RabbitMQ and Cloud Stream on a new project, I get the amqp starter, spring-cloud-stream, spring-cloud-stream-binder-rabbit and spring-cloud-stream-test-support.
If you instead only selects RabbitMQ intially; and subsequently add 'Cloud Stream' via edit starters. Then spring-cloud-stream-binder-rabbit and spring-cloud-stream-test-support are not being added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants