Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix randomized shell integration decoration bug for Windows pwsh #22675

Open
anthonykim1 opened this issue Dec 18, 2023 · 1 comment
Open

Fix randomized shell integration decoration bug for Windows pwsh #22675

anthonykim1 opened this issue Dec 18, 2023 · 1 comment
Assignees
Labels
area-repl bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team

Comments

@anthonykim1
Copy link

Reference: #22535 microsoft/vscode#199770
This would be making changes in vscode repository for shell integration to get better sense of Python REPL '>>>' prompt.

@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug area-repl labels Dec 18, 2023
@anthonykim1 anthonykim1 self-assigned this Dec 18, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Dec 18, 2023
@anthonykim1
Copy link
Author

Attempted to fix by defining Python prompt

		const pythonPrompt = lineText.match(/^(?<prompt>>>> )/g)?.groups?.prompt;
		if (pythonPrompt) {
			return {
				prompt: pythonPrompt,
				likelySingleLine: true
			};
		}

in vscode's commandDetectionCapability, but still getting colorless bubbles. Opting into windows heuristic from the Python extension side and defining Python prompt seemed to make the decoration less randomized, but still getting colorless decoration for Windows pwsh users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

1 participant