Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH broken when in terminal experiment #22339

Closed
karrtikr opened this issue Oct 25, 2023 · 8 comments
Closed

SSH broken when in terminal experiment #22339

karrtikr opened this issue Oct 25, 2023 · 8 comments
Assignees
Labels
experimenting Feature is part of an experiment triage-needed Needs assignment to the proper sub-team

Comments

@karrtikr
Copy link

karrtikr commented Oct 25, 2023

Originally posted by @Queuecumber in #11039 (comment)

My existing flow was broken by this change, it would be nice if there was a setting to re-enable the explicit source command. I can't see another workaround to fix it but I am open to trying some things.

Because of the way my server environment is setup I need to edit on a different machine than I launch my code on. To make this simpler I made a terminal like this:

"terminal.integrated.profiles.linux": {
        "login": {
            "path": "ssh",
            "args": [
                "<redacted hostname>",
                "-t",
                "cd ${workspaceFolder} && zsh"
            ]
        }
    },

this worked fine with the explicit source command but loses all the environment variables with the new method. I've tried a few things to set them such as adding ${env:PATH} before my zsh command and using the ssh argument -o SendEnv=PATH but nothing has worked so far.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 25, 2023
@karrtikr
Copy link
Author

@Queuecumber I've opened a new issue for you to further understand what might be causing the problem. First of all, please try the pre-release version of the extension:

image

@karrtikr
Copy link
Author

Secondly, if that doesn't work, can you describe in more details about how PATH is supposed to be and what it actually is because of the new feature?

@karrtikr
Copy link
Author

Also, reading the original issue it seems like you want SSH inside a SSH connection, do you think "Remote - SSH" extension can help you with that instead of configuring the terminal to do the SSH itself?

@karrtikr karrtikr self-assigned this Oct 25, 2023
@karrtikr karrtikr added info-needed Issue requires more information from poster experimenting Feature is part of an experiment labels Oct 25, 2023
@Queuecumber
Copy link

Thanks for opening this, let me try to answer your questions

can you describe in more details about how PATH is supposed to be and what it actually is because of the new feature?

It looks like the change in venv activation works by changing the PATH variable to point to the bin directory in the virtual environment. I don't know for sure that this is the only change so I recommend asking the engineers who designed this feature for more details on it.

do you think "Remote - SSH" extension can help you with that

Unfortunately "Remote - SSH" can't help me here. As I said in the original issue: I have to use the "Remote - SSH" extension to connect to a "Code Editing" server. From that server I have to ssh to a "Code Submission" server to run my code. I am not permitted to run the vscode server on the "Code Submission" server itself, it has to be a bare ssh session.

@github-actions github-actions bot removed the info-needed Issue requires more information from poster label Oct 25, 2023
@karrtikr
Copy link
Author

I see, did you try echo'ing PATH to see if it's actually set once you login into the ssh machine?

echo $PATH

It should be possible to send environment variables over SSH, if one asks https://chat.openai.com/ it lists a few ways to do it.

@karrtikr karrtikr added the info-needed Issue requires more information from poster label Oct 25, 2023
@Queuecumber
Copy link

I did echo $PATH and it's not set correctly, it's a good idea to ask chat gpt about it, let me try out its suggestions and get back to you

@github-actions github-actions bot removed the info-needed Issue requires more information from poster label Oct 25, 2023
@karrtikr karrtikr added the info-needed Issue requires more information from poster label Oct 25, 2023
Copy link

Hey @karrtikr, this issue might need further attention.

@karrtikr, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@karrtikr
Copy link
Author

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2023
@github-actions github-actions bot removed the info-needed Issue requires more information from poster label Nov 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
experimenting Feature is part of an experiment triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

2 participants