Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notification comes up when opening a workspace with no C/++ files #6489

Closed
connor4312 opened this issue Nov 10, 2020 · 2 comments
Closed
Labels
enhancement Improvement to an existing feature Language Service
Milestone

Comments

@connor4312
Copy link
Member

connor4312 commented Nov 10, 2020

Type: General

Describe the bug

  • OS and Version: Windows_NT x64 10.0.19041
  • VS Code Version: 1.52.0-insider (user setup)
  • C/C++ Extension Version: 1.1.1
  • A clear and concise description of what the bug is: I opened a folder containing only some .js files -- no .cpp, .h, .c, Makefiles, or anything like that. When I did so, the C++ update banner came up.

To Reproduce
Steps to reproduce the behavior:

  1. Open (apparently) any folder or workspace
  2. The update prompt has the possibility to come up

Expected behavior
Users get very annoyed and fatigued with notifications, most of which come from various extensions they have installed.

In this case, I installed the extension a while ago to work on some C++. But I just opened a new folder that's totally unrelated to any C/++ code. I don't care at all that the extension is updating stuff at this time; I had actually forgotten I had it installed.

If it fails, I might be interested, but even then I only really care the next time I go to work on C/++ code -- which could be in a day, a week, or never again.

Screenshots

@michelleangela michelleangela added enhancement Improvement to an existing feature installation labels Nov 11, 2020
@michelleangela michelleangela added this to Triage in 1.2.0 via automation Nov 11, 2020
@michelleangela michelleangela added this to the 1.2.0 milestone Nov 11, 2020
@sean-mcmanus
Copy link
Collaborator

We intentionally want to always download these files even if the current workspace is not C++; however, we could fix it so that the notification is hidden if the activation requirements for the C/C++ extension have not been hit.

@bobbrow bobbrow modified the milestones: 1.2.0, On Deck Jan 12, 2021
@bobbrow bobbrow removed this from Triage in 1.2.0 Jan 12, 2021
@bobbrow
Copy link
Member

bobbrow commented Dec 9, 2021

This will no longer be an issue when #8152 is complete. We will no longer need to have a separate download process.

@bobbrow bobbrow closed this as completed Dec 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement to an existing feature Language Service
Projects
None yet
Development

No branches or pull requests

5 participants