Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliSense-based features don't properly distinguish between -isystem and -iquote include paths #12207

Closed
sean-mcmanus opened this issue Apr 16, 2024 · 1 comment
Assignees
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

We only send IntelliSense a single list of include paths instead of separate "quote" and "system" paths.

Repro is like

#include <string>

int main()
{
    std::string s;
    return 0;
}

with

           "compilerPath": "C:/Program Files/LLVM/bin/clang++.exe",
            "compilerArgs": [
                "-iquote${workspaceFolder}/f1"
            ]

where f1 has a file named string.

It incorrectly picks up the -iquote path for <>.

Originally reported at #12198

@sean-mcmanus sean-mcmanus added bug Language Service Feature: Configuration An issue related to configuring the extension or IntelliSense labels Apr 16, 2024
@sean-mcmanus sean-mcmanus added this to the On Deck milestone Apr 16, 2024
@sean-mcmanus sean-mcmanus added this to Triage in 1.21 via automation Apr 16, 2024
@sean-mcmanus sean-mcmanus modified the milestones: On Deck, 1.21 Apr 16, 2024
@sean-mcmanus sean-mcmanus self-assigned this Apr 16, 2024
@sean-mcmanus sean-mcmanus moved this from Triage to In progress in 1.21 Apr 20, 2024
@sean-mcmanus sean-mcmanus moved this from In progress to Pull Request in 1.21 May 4, 2024
@sean-mcmanus sean-mcmanus modified the milestones: 1.21, 1.21.0 May 4, 2024
@sean-mcmanus sean-mcmanus moved this from Pull Request to Done in 1.21 May 17, 2024
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label May 17, 2024
@bobbrow bobbrow modified the milestones: 1.21.0, 1.21 Jun 17, 2024
@sean-mcmanus
Copy link
Collaborator Author

@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
Status: Done
1.21
Done
Development

No branches or pull requests

2 participants