Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate 'Add #include' code actions can appear if the same file exists at multiple locations #11989

Closed
sean-mcmanus opened this issue Feb 21, 2024 · 0 comments
Closed

Duplicate 'Add #include' code actions can appear if the same file exists at multiple locations #11989

sean-mcmanus opened this issue Feb 21, 2024 · 0 comments
Labels
bug Feature: Add '#include' Add '#include' code action on undefined symbols fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
1.20
Milestone
1.20.0

Comments

@sean-mcmanus
Copy link
Collaborator

i.e. have 2 paths in your include path (or use recursive includes) that have the same header file name and are both reached via the same include string path.

image

This wasn't found by me, but by an "internal team".
@sean-mcmanus sean-mcmanus added bug Language Service quick fix Feature: Add '#include' Add '#include' code action on undefined symbols labels Feb 21, 2024
@sean-mcmanus sean-mcmanus added this to the 1.19 milestone Feb 21, 2024
@sean-mcmanus sean-mcmanus added this to Triage in 1.19 via automation Feb 21, 2024
@sean-mcmanus sean-mcmanus moved this from Triage to Pull Request in 1.19 Feb 21, 2024
@sean-mcmanus sean-mcmanus modified the milestones: 1.19, 1.20.0 Feb 21, 2024
@sean-mcmanus sean-mcmanus removed this from Pull Request in 1.19 Feb 21, 2024
@sean-mcmanus sean-mcmanus added this to Triage in 1.20 via automation Feb 21, 2024
@sean-mcmanus sean-mcmanus moved this from Triage to Pull Request in 1.20 Feb 21, 2024
@sean-mcmanus sean-mcmanus moved this from Pull Request to Done in 1.20 Feb 23, 2024
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 23, 2024
This was referenced Feb 23, 2024
Open
Open
This was referenced Mar 5, 2024
Closed
Closed
This was referenced Mar 13, 2024
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Feature: Add '#include' Add '#include' code action on undefined symbols fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
No open projects
1.20
Done
Milestone
1.20.0
Development

No branches or pull requests
1 participant
@sean-mcmanus