Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uf2conv.py : wrong assert in calculation of upper address of hex format #53

Closed
elfmimi opened this issue Jun 16, 2021 · 1 comment
Closed

Comments

@elfmimi
Copy link

elfmimi commented Jun 16, 2021

assert (upper & 0xffff) == 0

instead segment address must be multiplied by 16 and added to each subsequent data record address.

cf. https://en.wikipedia.org/wiki/Intel_HEX

@mmoskal
Copy link
Member

mmoskal commented Jun 16, 2021

Not sure what this assert was doing there. The code already multiplies by 16 (by doing << 4). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants