Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify platform banner #2681

Closed
Evangelink opened this issue Apr 9, 2024 · 10 comments · Fixed by #2686
Closed

Simplify platform banner #2681

Evangelink opened this issue Apr 9, 2024 · 10 comments · Fixed by #2686
Assignees
Milestone

Comments

@Evangelink
Copy link
Member

Evangelink commented Apr 9, 2024

Summary

Simplify current platform banner

Background and Motivation

Multiple dotnet projects are moving toward a simplified banner and there is a similar request on VSTest microsoft/vstest#4869 so I think we should consider something similar here.

Proposed Feature

Move from

Microsoft(R) Testing Platform Execution Command Line Tool
Version: 3.4.0-dev (UTC 2024/04/09)
RuntimeInformation: win-x64 - .NET 8.0.3
Copyright(c) Microsoft Corporation.  All rights reserved.

to

.NET Testing Platform v1.2.0-preview.24253.1+3abae95b6 (UTC 2024/05/03) [win-x64 - .NET 8.0.4]

AB#2021757

@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Apr 9, 2024

MS Testing Platform v3.4.0-dev (24/04/09) [win-x64 - .NET 8.0.3]

@Evangelink
Copy link
Member Author

What about replacing MS with .NET so we would have .NET Testing Platform v3.4.0-dev (24/04/09) [win-x64 - .NET 8.0.3]

@MarcoRossignoli
Copy link
Contributor

I agree!

@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Apr 9, 2024

wondering if somewhere we should add the module name .NET Testing Platform v3.4.0-dev (24/04/09) [Contoso.Tests.dll win-x64 - .NET 8.0.3]

Not mandatory...dynamic length is maybe risky

@Evangelink
Copy link
Member Author

I am more afraid about confusions when we would have either multi-module cases or when you start to run with dotnet test but maybe this isn't a strong concern.

@nohwnd
Copy link
Member

nohwnd commented Apr 9, 2024

looks good, would keep 2024 in the date, it is not super easy to tell what it is without it.

is 3.4.0 MStest version but not the testing.platform version? What should xunit / nunit show if they use the new platform?

@Evangelink
Copy link
Member Author

is 3.4.0 MStest version but not the testing.platform version?

Mistake from me, I have run from my local so we are showing MSTest version but the final product is shipped from the other repo where the version is aligned.

What should xunit / nunit show if they use the new platform?

MSTest and other framework will have that display by default but #2657 will allow to either add extra line or replace current (depends on the design decisions we make there).

@nohwnd
Copy link
Member

nohwnd commented Apr 9, 2024

In that case:

.NET Testing Platform v1.1.0-dev (2024/04/09) [win-x64 - .NET 8.0.3] seems great..

What is the meaning of the date? Is that when the package was released or built? Or is that todays date?

@MarcoRossignoli
Copy link
Contributor

What is the meaning of the date? Is that when the package was released or built? Or is that todays date?

Build day

@Evangelink Evangelink self-assigned this Apr 10, 2024
@testplatform-bot
Copy link
Contributor

✅ Successfully linked to Azure Boards work item(s):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants