Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quake mode full screen doesn't reopen with full heightwhen closing and resummoning #16175

Open
Tracked by #8888
Lolle2000la opened this issue Oct 15, 2023 · 7 comments
Open
Tracked by #8888
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@Lolle2000la
Copy link

Windows Terminal version

1.18.2681.0

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

On a multi-monitor setup (primary monitor center: 2560x1400, other monitor left: 1920x1080). Does not happen with only one display (tested on Surface Pro 9)

  1. Summon quake mode window with the shortcut (bound to F10 on my machine)
    image
  2. Change to full screen with F11
    image
  3. Hide the quake mode window again
  4. Resummon the window
    image

Expected Behavior

Quake mode window reappears again in full screen mode, covering my screen in its entirety.

Actual Behavior

Quake mode window reappears covering around half of the montor. Pressing F11 once restores the normal quake window view, pressing it again puts in to full screen properly again.

@Lolle2000la Lolle2000la added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 15, 2023
@zadjii-msft
Copy link
Member

Huh. This is a bit like #12594, but definitely different. Thanks for the report!

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-Windowing Window frame, quake mode, tearout and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 16, 2023
@zadjii-msft zadjii-msft added this to the Backlog milestone Oct 16, 2023
@Lolle2000la
Copy link
Author

Having read this comment in the issue you referenced, I've tried whether the issue also appears on my 1080p monitor to the left of my primary monitor, and it doesn't weidly enough. Could it be that full screen remembers the position correctly but not the height? Though the fact that it doesn't restore with 1080p height on the primary 1440p monitor does speak against it fetching the false values I think.

@Lolle2000la
Copy link
Author

Ok I've set my primary monitor to be the monitor on the left in the windows settings, and after a restart of terminal the quake mode windows full screen gets correctly restored on my primary monitor but not the 1080p monitor.

I've also added the action I use to summon quake mode below, if that helps with diagnosing issues:

{
    "command": 
    {
        "action": "globalSummon",
        "desktop": "toCurrent",
        "dropdownDuration": 0,
        "monitor": "toMouse",
        "name": "_quake",
        "toggleVisibility": true
    },
    "keys": "f10"
}

@Digital-gitz
Copy link

        {
            "command": 
            {
                "action": "globalSummon",
                "desktop": "toCurrent",
                "MaximizeAfterToggle": true,
                "dropdownDuration": 0,
                "monitor": "toMouse",
                "name": "_quake",
                "toggleVisibility": true,
                "suppressApplicationTitle": true,
                "launchMode": "fullscreen"
            },
            "keys": "win+`"
        }

I have tried setting launch mode to full-screen just dose not work Docs not so helpful. this site seems to get it with max toggle but dose not work for me. link

@micmarty-deepsense
Copy link

any update on this?

@zadjii-msft
Copy link
Member

Nope. We'll make sure to update this thread when there is. In the meantime, might I recommend the Subscribe button?
image
That way you'll be notified of any updates to this thread, without needlessly pinging everyone on this thread ☺️


If someone in the community wants to take a crack at this, I'd more than welcome the help. IslandWindow.cpp is where I'd start by looking. We'd probably need to cache both size (for #12594) and fullscreen/maximized state (this thread) when the window gets dismissed, and use that size when it gets summoned.

(IIRC there's like, a WINODWPLACEMENT struct that might be what we're looking for)

@marcelbrode
Copy link

I want to share some observations, since I suffer the same issue.

It works on my secondary monitor (on the left), which is 16:9, but doesn't work on my main monitor, why is 21:9. I dunno if the resolution or the primary/secondary monitor is a thing, but maybe this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants