-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfork 'react/bridging/*' header files #13391
Comments
As is slated to be a permanent fork (not something waiting for an upstream change), related to our tools. Investigation into options for that happening while still not blocking the integration (thus the forks). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
During the 6/13 integration, a new ReactCommon file
EventEmitter.h
was brought in from upstream, and added as an include into the TurboModule.h file, which was causing the following errors:These errors are the result of the path of the TurboModule.h having two
ReactCommon
directories, resulting in the Visual Studio looking in the wrong directory during the build process and throwing the above error.In order to fix this issue, forks of
EventEmitter.h
,Function.h
,Base.h
andConvert.h
in thereact/bridigng
directory in ReactCommon had to be made. Additionally, some slight modifications were also made to the include statements inLongLivedObject.h
.Motivation
Resolve path issue and errors being caused by it
Basic Example
No response
Open Questions
No response
The text was updated successfully, but these errors were encountered: