Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN Button size changes when in press state #13332

Closed
acoates-ms opened this issue Jun 11, 2024 · 1 comment · Fixed by #13396
Closed

RN Button size changes when in press state #13332

acoates-ms opened this issue Jun 11, 2024 · 1 comment · Fixed by #13396

Comments

@acoates-ms
Copy link
Contributor

When you click on a RN button, the size of the button shrinks slightly, causing content below it to shift which is distracting.
(This can be seen clearly in the RN Gallery app)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Jun 11, 2024
@chrisglein
Copy link
Member

chrisglein commented Jun 13, 2024

There's a bottom border on the control that is displayed when idle:
Image

But not when pressed:
Image

Which is correct... but shouldn't affect the layout size.

Since this is in the JS button, in the platform override of Button.js, this affects Paper and Fabric.

Simplest fix to try: keep the border but make transparent color.

@chrisglein chrisglein added Area: Button and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Jun 13, 2024
@chrisglein chrisglein added this to the Backlog milestone Jun 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Jun 14, 2024
@chrisglein chrisglein added bug and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants