pac solution sync does not honour packagetype in solution.xml

[filcole]

If I clone a solution with unmanaged package type when I subsequently perform a solution sync I'd expect only the unmanaged solution to be cloned and the package type to stay as unmanaged. This does not happen, the unmanaged and managed solutions are exported and the solution is unpacked in 'both' mode.

Similarly, if I initially cloned in managed mode I'd expect that to be remembered and honoured by any future pac solution sync.

To reproduce:

1. pac solution clone --packagetype unmanaged --solution myAmazingThing
2. Notice that <managed>0</managed> is in Other\Solution.xml indicating solution is of the unmanaged export style
3. Now sync pac solution sync

Expected result

1. A single unmanaged export is performed
2. Solution.xml should be unchanged, and still have <managed>0</managed>

Actual result

1. Two solution exports are performed (unmanaged and managed)
2. Solution.xml is changed and now in 'both' mode, i.e. <managed>2</managed>

Workaround

Remember to type pac solution sync --packagetype unmanaged with the correct package type (as appropriate)