try sending with tx checksum offload #4587
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4587 +/- ##
==========================================
- Coverage 87.04% 86.79% -0.25%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 15106 15063 -43
- Misses 2248 2291 +43 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
Oct 2, 2024
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "installer": "https://github.com/microsoft/xdp-for-windows/releases/download/v1.0.1/xdp-for-windows.1.0.1.msi" | |||
| "installer": "https://github.com/microsoft/xdp-for-windows/releases/download/v1.1.0%2B5421c3c5/xdp-for-windows.1.1.0-prerelease+cfc4e4dd.msi" | |||
There was a problem hiding this comment.
A thought I had: How will MsQuic require the XDP version that supports the new offloads in the future? Should we rely on API version, or is there a way to require a specific XDP driver version?
There was a problem hiding this comment.
you should try loading the highest api versions, falling back gracefully, if a new API version is introduced. for some features, socket options will be added and shouldn't require an API version change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?