Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use API to check if something requires elevation instead of try/catch #635

Closed
dhoehna opened this issue May 19, 2023 · 1 comment
Closed

Use API to check if something requires elevation instead of try/catch #635

dhoehna opened this issue May 19, 2023 · 1 comment
Assignees
@AmelBawa-msft
Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Install Related to app installation in machine config flow Issue-Bug Something isn't working or needs investigation Priority-3 Resolution-By-Design This is intended to be implemented this way

Comments

@dhoehna
Copy link
Contributor

dhoehna commented May 19, 2023

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

TODO found at DevHome.SetupFlow.WinGetPackage.cs

Expected result

No response

Actual result

No response

Included System Information

No response

Included Extensions Information

No response
@dhoehna dhoehna added the Issue-Bug Something isn't working or needs investigation label May 19, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label May 19, 2023
@mathewleeza mathewleeza added the Area-Machine-Config Related to the machine configuration feature label May 25, 2023
@AmelBawa-msft AmelBawa-msft added the Area-Machine-Config-Install Related to app installation in machine config flow label Jun 1, 2023
@denelon denelon removed the Needs-Triage New issue that the core contributors need to triage label Jun 5, 2023
@AmelBawa-msft
Copy link
Contributor

This was originally suggested for the OOP calls to WinGet. However, as naturally all OOP COM calls need to be try/catch-ed for RPC errors, checking for the version is nice to have but not necessary as of today's requirements. I will close this issue and if necessary, in the future, I will re-activate it.

@krschau krschau added the Resolution-By-Design This is intended to be implemented this way label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmelBawa-msft AmelBawa-msft

Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Install Related to app installation in machine config flow Issue-Bug Something isn't working or needs investigation Priority-3 Resolution-By-Design This is intended to be implemented this way
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dhoehna @krschau @denelon @AmelBawa-msft @mathewleeza