Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "this" calls from Create Instance #631

Closed
dhoehna opened this issue May 19, 2023 · 1 comment
Closed

Remove "this" calls from Create Instance #631

dhoehna opened this issue May 19, 2023 · 1 comment
Assignees
@AmelBawa-msft
Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Repo Related to Repo setup, cloning, etc Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Available Available in a release Type-CodeHealth Related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Milestone
Dev Home v0.16

Comments

@dhoehna
Copy link
Contributor

dhoehna commented May 19, 2023

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

TODO found in DevHome.SetupFlow.RepoConfigTaskGroup.cs

Expected result

No response

Actual result

No response

Included System Information

No response

Included Extensions Information

No response
@dhoehna dhoehna added the Issue-Bug Something isn't working or needs investigation label May 19, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label May 19, 2023
@cinnamon-msft cinnamon-msft added Type-CodeHealth Related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. and removed Needs-Triage New issue that the core contributors need to triage labels May 20, 2023
@krschau krschau added the Area-Machine-Config Related to the machine configuration feature label Oct 16, 2023
@AmelBawa-msft AmelBawa-msft self-assigned this Nov 7, 2023
@kanismohammed kanismohammed added the Area-Machine-Config-Repo Related to Repo setup, cloning, etc label Nov 8, 2023
@krschau
Copy link
Contributor

krschau commented Jul 8, 2024

@AmelBawa-msft The task may be outdated but there's still a link to this issue in the code (

devhome/tools/SetupFlow/DevHome.SetupFlow/TaskGroups/RepoConfigTaskGroup.cs

Line 35 in 29c3ce6

// TODO https://github.com/microsoft/devhome/issues/631
). Can you just remove that comment in an upcoming PR?

@krschau krschau added the Resolution-Fix-Available Available in a release label Jul 8, 2024
@krschau krschau added this to the Dev Home v0.16 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmelBawa-msft AmelBawa-msft

Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Repo Related to Repo setup, cloning, etc Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Available Available in a release Type-CodeHealth Related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Projects
None yet
Milestone
Dev Home v0.16
Development

No branches or pull requests
5 participants
@dhoehna @krschau @cinnamon-msft @kanismohammed @AmelBawa-msft