Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy in pre-commit fixed #2117

Merged
merged 2 commits into from
Mar 21, 2024
Merged

mypy in pre-commit fixed #2117

merged 2 commits into from
Mar 21, 2024

Conversation

davorrunje
Copy link
Collaborator

Why are these changes needed?

It fixes the problem of importing optional targets to check typing with mypy in pre-commit.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.90%. Comparing base (a6a7409) to head (997d9d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2117   +/-   ##
=======================================
  Coverage   36.90%   36.90%           
=======================================
  Files          68       68           
  Lines        7061     7061           
  Branches     1541     1541           
=======================================
  Hits         2606     2606           
  Misses       4225     4225           
  Partials      230      230           
Flag Coverage Δ
unittests 36.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit fafc29e Mar 21, 2024
27 checks passed
@sonichi sonichi deleted the fix-mypy-precommit branch March 27, 2024 22:33
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* mypy in pre-commit fixed

* polishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants