Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union tuple type in rest argument can't accpect less argument. #48663

Open
beanbean97 opened this issue Apr 13, 2022 · 4 comments Β· May be fixed by #49218
Open

Union tuple type in rest argument can't accpect less argument. #48663

beanbean97 opened this issue Apr 13, 2022 · 4 comments Β· May be fixed by #49218
Labels
Bug A bug in TypeScript Help Wanted You can do this
Milestone

Comments

@beanbean97
Copy link

beanbean97 commented Apr 13, 2022

Bug Report

πŸ”Ž Search Terms

source has but target allows only

πŸ•— Version & Regression Information

  • This is a crash

⏯ Playground Link

Playground link with relevant code

πŸ’» Code

const func: (...args: [number, string] | [string, number]) => void = (item) => { }

πŸ™ Actual behavior

throw error

Type '(item: string | number) => void' is not assignable to type '(...args: [number, string] | [string, number]) => void'.
  Types of parameters 'item' and 'args' are incompatible.
    Type '[number, string] | [string, number]' is not assignable to type '[item: string | number]'.
      Type '[number, string]' is not assignable to type '[item: string | number]'.
        Source has 2 element(s) but target allows only 1.

πŸ™‚ Expected behavior

no error

@MartinJohns
Copy link
Contributor

Duplicate of #45972. Used search terms: `source has but target allows only"

@jcalz
Copy link
Contributor

jcalz commented Apr 13, 2022

I'm... not sure this is a duplicate of that, since there are no leading rest elements here to make the analysis weirder. Maybe the same underlying issue is happening in both places?

Anyway this one feels more like a bug to me, since the following is fine:

const f1: (x: string | number) => void = x => { }; 
const f2: (x: string | number, y: string | number) => void = f1; // okay
const f3: (...args: [number, string] | [string, number]) => void = f2; // okay

And while transitivity of assignability isn't the be-all and end-all for TypeScript, it's nice to be able to reason about things this way when possible.

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Help Wanted You can do this labels Apr 13, 2022
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Apr 13, 2022
@graphemecluster
Copy link
Contributor

Sorry to copy my #49218 (comment) here:

I think the easiest way to solve all the related issues is to wrap all the arguments into a tuple with rest syntax, i.e. item => {} should become (...[item]) => {} and ([first, ...rest], foo, ...args) => {} should work just like (...[[first, ...rest], foo, ...args]) => {}.

@cdauth
Copy link

cdauth commented Jun 25, 2024

Not exactly the same issue, but probably the same root cause:

const func: (arg1: string, arg2?: string) => void = (...args: [string] | [string, string]) => undefined; // Error

Also:

type Func = (...args: [string] | [string, string]) => void;
type Test = Func extends (arg1: string, ...args: any[]) => any ? true : false; // false

// Workaround:
type Test = Func extends (...args: infer Args) => any ? (Args extends [string, ...any[]] ? true : false) : false; // true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Help Wanted You can do this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants