Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureReq - Partner Center] Enable cross-browser V3 manifests #165

Open
lsmith77 opened this issue Jun 20, 2024 · 1 comment
Open

[FeatureReq - Partner Center] Enable cross-browser V3 manifests #165

lsmith77 opened this issue Jun 20, 2024 · 1 comment
Assignees
Labels
Feature the issue is a new feature request that we might eventually implement in the product Partner Center Label to filter all items related to Partner Center Tracked the issue is valid and tracked on our backlog.

Comments

@lsmith77
Copy link

**Is your feature request related to a problem?

We encountered this warning:
340078623-1fdaae31-190e-450a-ad3f-b62518e2f264

The issue is that we want to be able to use the same manifest for Firefox, which has different requirements. So from our point of view the validation in the Microsoft Edge store is too strict. Note that the Chrome store doesn't do such strict validation either.

Firefox still uses "scripts" https://stackoverflow.com/questions/75043889/manifest-v3-background-scripts-service-worker-on-firefox/78088358#78088358

Hence we changed our manifest from

  "background": {
    "service_worker": "js/background.bundle.js",
    "type": "module"
  },

To

  "background": {
    "service_worker": "js/background.bundle.js",
    "scripts": ["js/background.bundle.js"],
    "type": "module"
  },

to still support Firefox after the v3 migration.

Describe the solution you'd like
Ignore scripts in background if service_worker is present and pointing to the first element in a single element array in scripts

Describe alternatives you've considered
Ignore scripts in background

Additional context

@lsmith77 lsmith77 added Feature the issue is a new feature request that we might eventually implement in the product Partner Center Label to filter all items related to Partner Center labels Jun 20, 2024
@ManikanthMSFT ManikanthMSFT self-assigned this Jun 20, 2024
@sivMSFT sivMSFT added the Tracked the issue is valid and tracked on our backlog. label Jun 20, 2024
@ManikanthMSFT
Copy link
Collaborator

Hi @lsmith77, thank you for suggestion. We have forwarded your feedback and the proposed solution to our engineering team. They are currently reviewing it.

We understand the importance of this issue and once we have an update or need further information, we will get back to you promptly. We appreciate your contribution to improving the platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature the issue is a new feature request that we might eventually implement in the product Partner Center Label to filter all items related to Partner Center Tracked the issue is valid and tracked on our backlog.
Projects
None yet
Development

No branches or pull requests

3 participants