Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Edge crashes when user clicks a target="_blank" link in the sidepanel #145

Open
twschiller opened this issue Apr 11, 2024 · 5 comments
Open

Comments

@twschiller
Copy link

twschiller commented Apr 11, 2024

We're hitting a nasty bug where MS Edge crashes when the user clicks a target=_blank URL in the sidepanel:

MS Edge crashes and on next startup, our extension is no longer installed

I'm surprised other developers haven't hit up against this? Or is there an existing bug ticket

We're currently trying to reliably intercept the clicks to use window.open or browser.tabs.create instead. However, in some cases there might be a frame embedded in the side panel. Therefore, we'd have to have a contentScript to just try to intercept link clicks for any frame that might appear within the sidepanel

@mukul-p
Copy link

mukul-p commented Apr 18, 2024

Ack. We will get back after investigating this.

@twschiller
Copy link
Author

Appreciate the help! For others viewing this issue, here's our latest workaround for embedded iframes: pixiebrix/pixiebrix-extension#8223

@rishikramena-ms
Copy link

@twschiller can you share a sample extension for reproducing this crash? I tried reproducing the crash using the extension published on the Chrome Web Store but couldn't.

@twschiller
Copy link
Author

twschiller commented Apr 25, 2024

Hi @rishikramena-ms, thanks for investigating. Here's a repository with a minimal reproduction: https://github.com/pixiebrix/msedge-crash-repro.

Let me know if there's any other information I can provide!

I think the bug is related to the sidebar being tab-specific. It wasn't crashing for me when using a global sidebar

It might also be related to MS Edge's behavior of closing the tab-specific sidebar when opening a new tab: w3c/webextensions#588

I tried reproducing the crash using the extension published on the Chrome Web Store but couldn't.

We've added a mitigation: https://github.com/pixiebrix/pixiebrix-extension/blob/44a3b1a8b947ec82af349779c8e4baa4435db0ac/src/utils/openAllLinksInPopups.ts#L38-L38

And are also currently working on a mitigation for embedded frames using a content script: pixiebrix/pixiebrix-extension#8223

@twschiller
Copy link
Author

twschiller commented Jul 4, 2024

@rishikramena-ms any updates here? Do you need any additional information form us? This crashing bug is preventing our enterprise customers from using MS Edge with our product

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants