From 8ffd8d80e47e40ed6439123de85ab8bacffc1bb6 Mon Sep 17 00:00:00 2001 From: Guolin Ke Date: Tue, 16 Apr 2019 12:12:45 +0800 Subject: [PATCH] fix overflow in WeightedPercentile --- src/objective/regression_objective.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/objective/regression_objective.hpp b/src/objective/regression_objective.hpp index 214a13f58a01..bc6dcf90e1cf 100644 --- a/src/objective/regression_objective.hpp +++ b/src/objective/regression_objective.hpp @@ -65,7 +65,7 @@ namespace LightGBM { CHECK(threshold < weighted_cdf[pos]);\ T v1 = data_reader(sorted_idx[pos - 1]);\ T v2 = data_reader(sorted_idx[pos]);\ - if (weighted_cdf[pos + 1] - weighted_cdf[pos] > kEpsilon) {\ + if (weighted_cdf[pos + 1] - weighted_cdf[pos] >= 1.0f) {\ return static_cast((threshold - weighted_cdf[pos]) / (weighted_cdf[pos + 1] - weighted_cdf[pos]) * (v2 - v1) + v1); \ } else {\ return static_cast(v2);\