Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

DOC: Update installation guide in /docs/WSL.md #769

Merged
merged 7 commits into from
Aug 1, 2022

Conversation

arsenkhy
Copy link
Contributor

  • Removed long installation guide
  • Included new shorter guide to install WSL

Fixes #766

- Removed long installation guide
- Included new shorter guide to install WSL
@ghost
Copy link

ghost commented Jul 21, 2022

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks very much @arsenkhy for that contribution. Some small updates requested before merging, but I'm approving already.

docs/WSL.md Outdated Show resolved Hide resolved
docs/WSL.md Show resolved Hide resolved
@peterhessey peterhessey self-requested a review July 22, 2022 13:02
@peterhessey
Copy link
Contributor

LGTM once the changes Anton has requested have been added - will run workflows and approve after then :)

docs/WSL.md Outdated Show resolved Hide resolved
docs/WSL.md Outdated Show resolved Hide resolved
docs/WSL.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! I fixed minor typos.

@peterhessey
Copy link
Contributor

@arsenkhy you'll need to trim trailing whitespace from the file to pass CI checks (easily done using VS Code )

- Trimmed trailing whitespace to pass the CI checks
@ant0nsc
Copy link
Contributor

ant0nsc commented Jul 26, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ant0nsc
Copy link
Contributor

ant0nsc commented Jul 26, 2022

@arsenkhy , I had to manually start the PR build, once that has come back as green, feel free to merge!

@peterhessey
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterhessey
Copy link
Contributor

Not sure why this is timing out, running again one more time and will investigate more thoroughly if it fails!

@peterhessey
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterhessey peterhessey merged commit 4e12cec into microsoft:main Aug 1, 2022
fepegar added a commit that referenced this pull request Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WSL instructions can be updated
3 participants