Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Documented flag no-train does not seem to exist #518

Closed
dumbledad opened this issue Jun 30, 2021 · 2 comments
Closed

Documented flag no-train does not seem to exist #518

dumbledad opened this issue Jun 30, 2021 · 2 comments

Comments

@dumbledad
Copy link
Contributor

dumbledad commented Jun 30, 2021

The documentation mentions the no_train parameter, i.e. in here, but there is no mention of that flag in the code. (N.B. the flag is also inconsistently using hyphen when others use underscore).

AB#4191

@JonathanTripp
Copy link
Contributor

In the class GenericConfig there is a function add_boolean_argument that has special handling for boolean arguments. If the default is True then this creates two exclusive argument options: --flag=True|False or --no-flag. The hyphen may be unusual for this project but it will be standard in argparser 3.8 onwards. See: https://docs.python.org/3/library/argparse.html where the statement

parser.add_argument('--foo', action=argparse.BooleanOptionalAction)

produces --no-foo

@ant0nsc
Copy link
Contributor

ant0nsc commented Jul 27, 2021

by design

@ant0nsc ant0nsc closed this as completed Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants