Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fixes for mounting and matplotlib problems #515

Merged
merged 12 commits into from
Jul 15, 2021
Merged

Fixes for mounting and matplotlib problems #515

merged 12 commits into from
Jul 15, 2021

Conversation

ant0nsc
Copy link
Contributor

@ant0nsc ant0nsc commented Jun 28, 2021

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change.
  • Add unit tests for all functions that you introduced or modified.
  • Run PyCharm's code cleanup tools on your Python files.
  • Link the correct GitHub issue for tracking.
  • Update the Changelog file: Describe your change in terms of
    Added/Changed/Removed/... in the "Upcoming" section.
  • When merging your PR, replace the default merge message with a description of your PR,
    and if needed a motivation why that change was required.

@ant0nsc ant0nsc enabled auto-merge (squash) June 28, 2021 10:57
@ant0nsc ant0nsc disabled auto-merge June 28, 2021 22:17
@ant0nsc
Copy link
Contributor Author

ant0nsc commented Jun 28, 2021

This PR should not yet be merged, a first PR build failed in the dataset mounting.

Shruthi42
Shruthi42 previously approved these changes Jun 30, 2021
JonathanTripp
JonathanTripp previously approved these changes Jun 30, 2021
dumbledad
dumbledad previously approved these changes Jun 30, 2021
@ant0nsc ant0nsc enabled auto-merge (squash) June 30, 2021 08:43
@ant0nsc ant0nsc disabled auto-merge June 30, 2021 14:53
@ant0nsc ant0nsc dismissed stale reviews from dumbledad, JonathanTripp, and Shruthi42 via d4e272b July 7, 2021 19:14
Copy link
Contributor

@dumbledad dumbledad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ant0nsc ant0nsc merged commit ae82089 into main Jul 15, 2021
@ant0nsc ant0nsc deleted the antonsc/fixes branch July 15, 2021 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants