Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Model baseline comparison shouldn't allow duplicates #506

Open
JonathanTripp opened this issue Jun 23, 2021 · 0 comments
Open

Model baseline comparison shouldn't allow duplicates #506

JonathanTripp opened this issue Jun 23, 2021 · 0 comments
Assignees
Labels
good first issue Good for newcomers not urgent Not needed for current work

Comments

@JonathanTripp
Copy link
Contributor

JonathanTripp commented Jun 23, 2021

The model config parameter comparison_blob_storage_paths takes a list of tuples, (name, container). The name is purely descriptive , and has no further meaning, but it is important that they are distinct otherwise multiple datasets from different containers may be merged in an unpredictable way. Essentially, it is better if this is a dict[name, container]. Add this validation to the validate function.

AB#4149

@ant0nsc ant0nsc added the good first issue Good for newcomers label May 16, 2022
@peterhessey peterhessey added the not urgent Not needed for current work label May 19, 2022
@peterhessey peterhessey self-assigned this Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers not urgent Not needed for current work
Projects
Status: No status
Development

No branches or pull requests

3 participants