Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Better diagnostics: Regression error plots #375

Open
ant0nsc opened this issue Jan 28, 2021 · 0 comments
Open

Better diagnostics: Regression error plots #375

ant0nsc opened this issue Jan 28, 2021 · 0 comments
Labels
feature parity Reach feature parity with code before Lightning move not urgent Not needed for current work reporting and diagnostics Improvements to diagnostics and reporting

Comments

@ant0nsc
Copy link
Contributor

ant0nsc commented Jan 28, 2021

Regression models should at rank zero write this a prediction/target plot like this in the old code:

    if self._should_save_regression_error_plot(self.current_epoch):
        error_plot_name = f"error_plot_{self.train_val_params.epoch}"
        path = str(self.config.outputs_folder / f"{error_plot_name}.png")
        plot_variation_error_prediction(epoch_metrics.get_labels(), epoch_metrics.get_predictions(), path)
        logger = self.config.azure_loggers_train if is_training else self.config.azure_loggers_val
        logger.log_image(error_plot_name, path)

AB#3914

@ant0nsc ant0nsc added the reporting and diagnostics Improvements to diagnostics and reporting label Feb 2, 2021
@ant0nsc ant0nsc added this to Backlog in InnerEye via automation Feb 3, 2021
@ant0nsc ant0nsc moved this from Backlog to Bugs & Feature Parity in InnerEye Feb 3, 2021
@ant0nsc ant0nsc added the feature parity Reach feature parity with code before Lightning move label Feb 3, 2021
@ant0nsc ant0nsc moved this from Bugs & Feature Parity to Planned in InnerEye Feb 3, 2021
@ant0nsc ant0nsc added the not urgent Not needed for current work label Feb 4, 2021
@ant0nsc ant0nsc removed this from Planned in InnerEye Feb 4, 2021
@ant0nsc ant0nsc added no changelog needed CHANGELOG.md does not need to be updated in this PR and removed no changelog needed CHANGELOG.md does not need to be updated in this PR labels Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature parity Reach feature parity with code before Lightning move not urgent Not needed for current work reporting and diagnostics Improvements to diagnostics and reporting
Projects
None yet
Development

No branches or pull requests

1 participant