This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Ensure that models are registered with consistent file structure #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 9, 2020
This reverts commit 72fda9c
…InnerEye-DeepLearning into antonsc/230_inference
Shruthi42
reviewed
Nov 11, 2020
Shruthi42
previously approved these changes
Nov 13, 2020
melanibe
reviewed
Nov 13, 2020
Shruthi42
previously approved these changes
Nov 13, 2020
fix registration issue
Shruthi42
approved these changes
Nov 16, 2020
melanibe
approved these changes
Nov 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_scoringcould be deprecated in principle, but leaving it there if we need for legacy models.submit_for_inference: Previous test was using a hardcoded legacy model, meaning that any changes to model structure could have broken the scriptsubmit_for_inferenceis no longer submitted from the big AzureML run, shortening the runtime of that part of the PR build. Instead, it is triggered after theTrainViaSubmodulepart of the build. The corresponding AzureML experiment is no longermodel_inference, but the same experiment as all other AzureML runs.submit_for_inferencewas previously running on the expensivetraining-nd24cluster, now on the cheapernc12.submit_for_inferencenow correctly uses thescore.pyfile that is inside of the model, rather than copying it from the repository root.