Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple error with function "detour_skip_jmp" by Hook System function on Windows x64 #87

Open
JohnWins opened this issue Oct 24, 2019 · 2 comments
Labels
bug Something isn't working help-wanted This issue / or pull request is up for grabs for anyone in the community to help. needs-author-feedback This issue / or pull request requires author feedback before more action can be taken. status-no recent activity

Comments

@JohnWins
Copy link

hi,
function "detour_skip_jmp" does work for x86 api hook routine, but not ok for x64.
detours will not detect the inner function is a import vector or something after a long jmp.
So it does fail when hook a x64 function on that condition.

But also come up with a small patch for detour_skip_jmp.
https://cdn1.imggmi.com/uploads/2019/10/24/8a2798e183931867e343354ff3c746bd-full.png

x86_asm_code:
https://cdn1.imggmi.com/uploads/2019/10/24/7dfbcfd5408c4a327b871648f9cc3709-full.png

x64_asm_code:
https://cdn1.imggmi.com/uploads/2019/10/24/c8d92586582d0bc4b45e107f769ff9a6-full.png

@bgianfo bgianfo added the bug Something isn't working label Aug 26, 2020
@bgianfo
Copy link
Contributor

bgianfo commented Aug 27, 2020

Hey @JohnWins, would you mind submitting a PR to fix the issue you found?

The links are all dead at this point 😞.

@bgianfo bgianfo added needs-author-feedback This issue / or pull request requires author feedback before more action can be taken. help-wanted This issue / or pull request is up for grabs for anyone in the community to help. labels Jan 24, 2021
@microsoft-github-policy-service

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help-wanted This issue / or pull request is up for grabs for anyone in the community to help. needs-author-feedback This issue / or pull request requires author feedback before more action can be taken. status-no recent activity
Projects
None yet
Development

No branches or pull requests

2 participants