You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When I use syslog to test my project, I found there is a bug in error process of GetQueuedCompletionStatus in syslogd.cpp (line 334).
The else branch will never be triggered.
And in this logic if client closed a piep, a work thread will exit.
Expected behavior
I thought thread will exit only when both return value is false and lpo is NULL, as description in doc of GetQueuedCompletionStatus:
If a call to GetQueuedCompletionStatus fails because the completion port handle associated with it is closed while the call is outstanding, the function returns FALSE, *lpOverlapped will be NULL, and GetLastError will return ERROR_ABANDONED_WAIT_0.
I will create a PR for it.
Detours version
current master
The text was updated successfully, but these errors were encountered:
Describe the bug
When I use syslog to test my project, I found there is a bug in error process of GetQueuedCompletionStatus in syslogd.cpp (line 334).
The else branch will never be triggered.
And in this logic if client closed a piep, a work thread will exit.
Expected behavior
I thought thread will exit only when both return value is false and lpo is NULL, as description in doc of GetQueuedCompletionStatus:
I will create a PR for it.
Detours version
current master
The text was updated successfully, but these errors were encountered: