Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] narrator does not announce "Required" on some inputs when IsRequired is true. #8915

Closed
dhoehna opened this issue May 15, 2024 · 1 comment

Comments

@dhoehna
Copy link

dhoehna commented May 15, 2024

Target Platforms

Other

SDK Version

1.5

Application Name

DevHome

Problem Description

Narrator does not read say an item is required when setting "IsRequired" to true on a Input.ChoiceSet.

Screenshots

image

Narrator does not mention if any combo box is required. To validate, I removed "Value" from the adaptive card JSON to not have a pre-selected value. Narrator still did not say "Required"

Card JSON

{
  "type": "AdaptiveCard",
  "$schema": "http:https://adaptivecards.io/schemas/adaptive-card.json",
  "version": "1.5",
  "body": [
    {
      "type": "ColumnSet",
      "spacing": "large",
      "columns": [
        {
          "type": "Column",
          "width": "auto",
          "items": [
            {
              "type": "Input.Text",
              "id": "NewEnvironmentName",
              "label": "${EnterNewEnvironmentTextBoxLabel}",
              "maxLength": 100,
              "isRequired": true,
              "errorMessage": "${DevBoxTextBoxErrorMessage}",
              "regex": "${DevBoxNameRegex}",
              "spacing": "large",
              "value": "${TextBoxText}"
            }
          ]
        }
      ]
    },
    {
      "type": "ColumnSet",
      "spacing": "large",
      "columns": [
        {
          "type": "Column",
          "width": "stretch",
          "items": [
            {
              "type": "Input.ChoiceSet",
              "id": "ProjectsComboBox",
              "label": "${ProjectComboBoxLabel}",
              "devHomeChildChoiceSetId": "PoolsComboBox",
              "devHomeSelectionChangedDataForChildChoiceSet": "${SelectionChangedDataForChildChoiceSet}",
              "devHomeRefreshChildChoiceSetOnSelectionChanged": true,
              "isRequired": true,
              "errorMessage": "${DevBoxProjectComboBoxErrorMessage}",
              "style": "compact",
              "value": "${SelectedProjectIndex}",
              "choices": [
                {
                  "$data": "${ProjectList}",
                  "title": "${title}",
                  "value": "${value}"
                }
              ]
            }
          ]
        }
      ]
    },
    {
      "type": "ColumnSet",
      "spacing": "large",
      "columns": [
        {
          "type": "Column",
          "width": "stretch",
          "items": [

            {
              "type": "Input.ChoiceSet",
              "id": "PoolsComboBox",
              "devHomeParentChoiceSetId": "ProjectsComboBox",
              "label": "${DevBoxPoolComboBoxLabel}",
              "isRequired": true,
              "errorMessage": "${DevBoxPoolsComboBoxErrorMessage}",
              "placeholder": "${DevBoxPoolsPlaceHolder}",
              "style": "compact",
              "value": "${SelectedPoolIndex}",
              "devHomeChoicesData": [
                {
                  "$data": "${PoolsList}",
                  "title": "${title}",
                  "subtitle": "${subtitle}",
                  "value": "${value}"
                }
              ]
            }
          ]
        }
      ]
    },
    {
      "type": "ActionSet",
      "id": "DevHomeTopLevelActionSet",
      "actions": [
        {
          "id": "DevHomeMachineConfigurationNextButton",
          "type": "Action.Submit",
          "title": "${PrimaryButtonLabelForCreationFlow}"
        },
        {
          "id": "DevHomeMachineConfigurationPreviousButton",
          "type": "Action.Submit",
          "title": "${SecondaryButtonLabelForCreationFlow}"
        }
      ]
    }
  ]
}

Sample Code Language

No response

Sample Code

No response

@vagpt
Copy link
Collaborator

vagpt commented Jun 7, 2024

Closing this issue here as of now this issue is tracking with below URL -

#8931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants