Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Deprecation warnings not updated for fontStyles->fontTypes rename #3506

Closed
paulcam206 opened this issue Oct 2, 2019 · 3 comments · Fixed by #3529
Closed

[.NET] Deprecation warnings not updated for fontStyles->fontTypes rename #3506

paulcam206 opened this issue Oct 2, 2019 · 3 comments · Fixed by #3529
Assignees

Comments

@paulcam206
Copy link
Member

Platform

  • .NET HTML
  • .NET WPF

Description

FontStyle was renamed to FontType, but an older deprecation warning wasn't updated to reflect this:

[JsonProperty(DefaultValueHandling = DefaultValueHandling.Ignore)]
[Obsolete("AdaptiveHostConfig.FontFamily has been deprecated. Use AdaptiveHostConfig.FontStyles.Default.FontFamily", false)]
public string FontFamily { get; set; }
[JsonProperty(DefaultValueHandling = DefaultValueHandling.Ignore)]
[Obsolete("AdaptiveHostConfig.FontSizes has been deprecated. Use AdaptiveHostConfig.FontStyles.Default.FontSizes", false)]
public FontSizesConfig FontSizes { get; set; } = new FontSizesConfig();
[JsonProperty(DefaultValueHandling = DefaultValueHandling.Ignore)]
[Obsolete("AdaptiveHostConfig.FontWeights has been deprecated. Use AdaptiveHostConfig.FontStyles.Default.FontWeights", false)]
public FontWeightsConfig FontWeights { get; set; } = new FontWeightsConfig();

@shalinijoshi19
Copy link
Member

@nesalang can you pick this up? This should be part of our October patch. Thanks

@jwoo-msft
Copy link
Member

@nesalang can you pick this up? This should be part of our October patch. Thanks

sure

@ghost
Copy link

ghost commented Nov 5, 2019

🎉This issue was addressed in #, which has now been successfully released as [email protected].:tada:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants