Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

berkeley-schema-fy24: Schema version underlying SchemaView instance changes from one release to the next #2100

Open
eecavanna opened this issue Jul 2, 2024 · 1 comment
Assignees
Labels
berkeley-fy24-refactor Label to describe issues created during the December 2023 hackathon for schema refactor bug Something isn't working

Comments

@eecavanna
Copy link
Collaborator

One of the "Berkeley" migrators creates a SchemaView of the schema contained within the Python package. When the migrator was written, that schema was at some version. When the migrator gets run, the schema might be at some different version. This is a logical bug.

Here's a link to the offending code: migrator_from_10_2_0_to_11_0_0_part_10.py

@eecavanna eecavanna added bug Something isn't working berkeley-fy24-refactor Label to describe issues created during the December 2023 hackathon for schema refactor labels Jul 2, 2024
@eecavanna eecavanna changed the title berkeley-schema-fy24: Schema version underlying SchemaView instance will change from one release to the next berkeley-schema-fy24: Schema version underlying SchemaView instance changes from one release to the next Jul 2, 2024
@eecavanna eecavanna self-assigned this Jul 4, 2024
@turbomam
Copy link
Member

We could pin the SchemView() so that its input is a YAML file from a named release if you can tolerate a dependency on a GH raw file. Most LinkML methods that operate on a schema are very tolerant of different input types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
berkeley-fy24-refactor Label to describe issues created during the December 2023 hackathon for schema refactor bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants